On Aug 7, 2016, at 7:07 PM, Philip Guenther <[email protected]> wrote:
> On Sun, 7 Aug 2016, Guy Harris wrote:
> ...
>> --- lib/libc/net/ethers.c 14 Sep 2015 11:01:47 -0000 1.24
>> +++ lib/libc/net/ethers.c 8 Aug 2016 01:28:39 -0000
> ...
>> @@ -144,7 +144,7 @@
>> }
>> #endif
>> if (ether_line(buf, &try, hostname) == 0 &&
>> - memcmp((void *)&try, (void *)e, sizeof(try)) == 0) {
>> + memcmp((void *)&try, (const void *)e, sizeof(try)) == 0) {
>
> Isn't it simpler and better to completely delete both those casts?
Given that you won't be running the compiler with -Wc++-compat, yes, it is.
