On Mon, Oct 03, 2016 at 12:23:08PM +0200, Martin Pieuchot wrote: > Index: netinet/in.c > =================================================================== > RCS file: /cvs/src/sys/netinet/in.c,v > retrieving revision 1.129 > diff -u -p -r1.129 in.c > --- netinet/in.c 4 Sep 2016 10:32:01 -0000 1.129 > +++ netinet/in.c 3 Oct 2016 10:19:31 -0000 > @@ -637,8 +637,7 @@ in_ifinit(struct ifnet *ifp, struct in_i > * error occured, put back the original address. > */ > ifa_add(ifp, &ia->ia_ifa); > - rt_ifa_addlocal(&ia->ia_ifa); > - > + error = rt_ifa_addlocal(&ia->ia_ifa); > if (error) > goto out; >
Here you may reset the error from the if_ioctl() call. Note that there is no "if (error) goto out" before. The other chunks are OK. bluhm
