On Fri, Dec 30, 2016 at 06:49:22PM +0900, YASUOKA Masahiko wrote: > On Fri, 30 Dec 2016 19:38:20 +1100 > Jonathan Gray <[email protected]> wrote: > > On Fri, Dec 30, 2016 at 05:33:44PM +0900, YASUOKA Masahiko wrote: > >> On Thu, 29 Dec 2016 14:53:20 -0600 > >> Ryan <[email protected]> wrote: > >> > Oh before I forget, while I was reading through the code I noticed what > >> > appears to be a typo in sys/arch/amd64/stand/efiboot/eficall.h: > >> > > >> > #define EFI_CALL(...) \ > >> > _efi_call_fn(__VA_ARGS__, _call_9, _call_8, _call_7, _call_6, > >> > _call_5, \ > >> > _call_4, _call_3, _call_2, _call_1, _call_1)(__VA_ARGS__) > >> > #endif > >> > > >> > It looks like the second instance of _call_1 should be _call_0 (which is > >> > defined earlier), unless I am totally misreading this. > >> > >> I commited this already. Thanks. > > > > Shouldn't this change also be made to armv7 and arm64? > > Yes, I committed for armv7 and arm64 as well. > > Thanks,
Thanks, in this particular case they use the #define EFI_CALL(_func_, ...) (_func_)(__VA_ARGS__) path, it is good to keep them in sync though.
