On Monday 03 April 2017 11:37:19 Stuart Henderson wrote: > On 2017/04/03 11:19, Stuart Henderson wrote: > > That format string doesn't show up in nginx at all. But it is in > > /usr/src/lib/libcrypto/asn1/t_x509.c. Looks like "f" not getting set > > if there are no fractions of a second in the ASN1_GENERALIZEDTIME? > > Too ugly?
Given the rest of this function, probably not... but why not just change the initialisation? char *f = ""; > Index: t_x509.c > =================================================================== > RCS file: /cvs/src/lib/libcrypto/asn1/t_x509.c,v > retrieving revision 1.27 > diff -u -p -r1.27 t_x509.c > --- t_x509.c 29 Jan 2017 17:49:22 -0000 1.27 > +++ t_x509.c 3 Apr 2017 10:31:55 -0000 > @@ -435,7 +435,8 @@ ASN1_GENERALIZEDTIME_print(BIO *bp, cons > } > > if (BIO_printf(bp, "%s %2d %02d:%02d:%02d%.*s %d%s", > - mon[M - 1], d, h, m, s, f_len, f, y, (gmt) ? " GMT" : "") <= 0) > + mon[M - 1], d, h, m, s, f_len, f ? f : "", y, > + (gmt) ? " GMT" : "") <= 0) > return (0); > else > return (1);
