On Wed, Apr 05, 2017 at 06:35:21AM +0000, Tinker wrote:
> Hi,
>
> The axen(4) ( http://man.openbsd.org/axen.4 ) driver occasionally prints a
> "checksum err (pkt#N)" warning message to the console/dmesg. The rate I'm
> observing currently is about three per week, and what I see is that it has
> no negative impact on the adapter's operation (i.e. what I see is that it's
> a warning and not an error).
>
> Observed on AMD64 6.0 and from the sourcecode the behavior appears to me to
> be unmodified in 6.1 .
>
> It's produced by a printf in dev/usb/if_axen.c (
> https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/dev/usb/if_axen.c?rev=1.24&content-type=text/x-cvsweb-markup
> ).
>
> Right now, luckily this printf line is the only match when grepping for
> "checksum err (pkt" in the kernel sources, so it's easy to resolve the cause
> and see that it's only a debug warning.
>
> I would suggest to prefix it with "axen: " or alike, to decrease any risk
> for user freak-out over it -or, maybe even more relevant would be to disable
> it altogether - I guess the other NIC drivers simply silently ignore any
> broken-checksum frames they receive?
>
> Thanks,
> Tinker
>
Yes, some cleanup is due here.
I suggest you send us a patch that makes it a DPRINTF. You could also add
a line ifp->if_ierrors++;' at the same place so the error is counted in
netstat -I axen0.
And there are some similar printfs in the same function that should get
the same treatment, such as this one: printf("rxeof: too large transfer\n");
