On Fri, May 05, 2017 at 10:05:19AM +0000, Seiya Kawashima wrote: > >Synopsis: Invalid syntax error from syntax_is_time() on ldapd(8) when > >adding entries > >Category: system > >Environment: > System : OpenBSD 6.1 > Details : OpenBSD 6.1-current (GENERIC.MP) #50: Thu May 4 11:52:48 > MDT 2017 > > [email protected]:/usr/src/sys/arch/amd64/compile/GENERIC.MP > > Architecture: OpenBSD.amd64 > Machine : amd64 > >Description: > Thank you for the great work on ldapd(8). > > ldapd(8) had been working great until I moved to OpenBSD 6.1-current > (GENERIC.MP) #50. > The entire dmesg is attached at the end of this report. If this report > is not relevant, > please discard it. The relevant parts are syntax_is_gentime(), > syntax_is_utctime and > syntax_is_time() on syntax.c. I still wonder why it worked without the > fix shown below and > now it doesn't work without any modification.
Thanks for reporting and investigating this. I've commited a fix, also fixing the check for timezones on generalized times. What happened here was that in r1.4 of syntax.c, we corrected the CHECK_RANGE macro, which previously wouldn't work properly following an 'if' statement with no braces. The function had accidentally been written to rely on the effects of doing this, and unfortunately we didn't notice that fixing the macro caused the function to misbehave.
