On Thu, Apr 05, 2018 at 11:41:51AM +0200, Patrick Wildt wrote: > I have seen that issue as well. I think it's because we are now > being passed the data and we don't have to do the copyin ourselves. > When the conversion happened, someone forgot to remove the copyin. > > Does this help?
OK bluhm@ > diff --git a/sys/tmpfs/tmpfs_vfsops.c b/sys/tmpfs/tmpfs_vfsops.c > index 7fe10c5f00e..b4d671d1160 100644 > --- a/sys/tmpfs/tmpfs_vfsops.c > +++ b/sys/tmpfs/tmpfs_vfsops.c > @@ -121,9 +121,6 @@ tmpfs_mount(struct mount *mp, const char *path, void > *data, > if (tmpfs_mem_info(1) < TMPFS_PAGES_RESERVED) > return EINVAL; > > - error = copyin(data, args, sizeof(struct tmpfs_args)); > - if (error) > - return error; > if (args->ta_root_uid == VNOVAL || args->ta_root_gid == VNOVAL || > args->ta_root_mode == VNOVAL) > return EINVAL;
