On 1.10.2018. 14:09, Visa Hankala wrote:
> On Mon, Oct 01, 2018 at 01:50:59PM +0200, Hrvoje Popovski wrote:
>> Hi all,
>>
>> while testing sasha's "pfsync: avoid a recursion on PF_LOCK" diff i
>> manage to get panic. first i thought that this panic have something to
>> do with sasha@ work but i can easily reproduce it on clean -current.
>>
>> while firewall is under stress and forwarding traffic and i'm doing this
>> in loop
>>
>> ifconfig pfsync0 destroy && sleep 2 && sh netstart pfsync0 && sleep 2
>>
>> i'm getting this panic:
>>
>>
>> uvm_fault(0xffffffff81d51fe8, 0x8, 0, 2) -> e
>> kernel: page fault trap, code=0
>> Stopped at softclock_thread+0xef: movq %rdx,0x8(%rcx)
>> ddb{0}>
>
> pfsync_clone_destroy() lacks proper locking and its timeout cancellation
> is not robust. Please try the patch below.
i can't reproduce panic with this diff .... thank you ..
