On Mon, Oct 01, 2018 at 02:44:30PM +0200, Alexander Bluhm wrote: > On Mon, Oct 01, 2018 at 02:06:42PM +0200, Reyk Floeter wrote: > > On Wed, Sep 26, 2018 at 12:36:50PM +0200, Sebastian Benoit wrote: > > > > > about:config network.http.keep-alive.timeout 115 > > > > > > > > > > So I think we should increase httpd's default to 120 seconds. Then > > > > > Firefox closes the persistent connection first and we don't get > > > > > this ugly error messages. > > > > > > > > > > ok? > > > > > > > > Sorry, but i think sending a 408 is wrong: > > Yes, but would it make sense to set the server timout to 120 anyway > as the Firefox client timeout is 115?
Please don't. You can get quickly into trouble by setting keep-alive timeout to 120 seconds. At least on busy systems a limit below 60s is more reasonable. I see no need to optimise this for one particular browser. > > > Here is a diff that should make httpd close the connection without any > > > response if it did not receive anything yet (also in the keep-alive case, > > > if > > > it is waiting for the next request). > > > > Thanks for the analysis. > > I also think just closing is the correct behavior. > > > > Instead of using a new variable clt_seendata this could probably be just a > > > new value for clt_toread? > > > > > > > Why not? TOREAD already became some some kind of a state machine, so > > why no adding TOREAD_HTTP_INIT? > > I don't know the design of httpd well enough to judge this. Me neither but this looks better than the previous diff. -- :wq Claudio
