Hey,
On 10/25/18 8:24 AM, Mike Larkin wrote:
We have a theory this is a bug in pms(4).
Can you use the kernel with the commented out line that does not do a
wsdisplay_suspend, and boot -c ?
ukc> disable pms
ukc> quit
then do a zzz/ZZZ/resume?
This will disable the mouse/trackpad, so you might need to use a usb mouse
for this test.
If this works, we can dig further.
-ml
i did exactly what you suggested but there is no change. I get the same
result.
As Theo rightfully pointed out to me my bug report and also my first
response is garbage and confusing. I am sorry about that. I try to
clarify what i wanted to say (sorry, i am not a native speaker)
Lets ditch zzz from the report because this is not working at all at the
moment. Lets focus on ZZZ in this report.
I did the following steps:
1: I build the kernel with wsdisplay_suspend() commented out.
2: I bootet the laptop and did a boot -c.
3: I entered my passphrase to unlook the disc.
4: I disabled pms and quit so the boot would continue.
5: I logged in as my normal user (i also did a try as root) and did ZZZ.
6: I started the laptop again.
7: The laptop found unhibernate detected: switching to /bsd.booted
8: The boot process gets stuck at the following screen
https://i.imgur.com/NlYyhBv.jpg The device is totally unresponsive. I
cannot press any keys. This is before the line unhibernating @ block
32987271 happens.
9: I hard reset the device.
10: The laptop shows unhibernate detected: switching to /bsd.booted again.
11: The now the boot messages show the message: unhibernating @ block
32987271
12: Now the device is bootet up again with the previous state.
I did this 5 times. The first boot atempt always gets stuck at the exact
same line. See the picture from above. The second boot atempt always
works fine after hard reseting the laptop via pressing down the power
button.
Index: pms.c
===================================================================
RCS file: /cvs/src/sys/dev/pckbc/pms.c,v
retrieving revision 1.87
diff -u -p -u -r1.87 pms.c
--- pms.c 13 May 2018 14:48:19 -0000 1.87
+++ pms.c 25 Oct 2018 06:30:00 -0000
@@ -834,8 +834,10 @@ pms_change_state(struct pms_softc *sc, i
pms_dev_enable(sc);
break;
- case PMS_STATE_DISABLED:
case PMS_STATE_SUSPENDED:
+ sc->poll = 1;
+ /* FALLTHROUGH */
+ case PMS_STATE_DISABLED:
pms_dev_disable(sc);
if (sc->protocol->disable)
I also did 5 test runs with those proposed changes from Theo. The exact
same thing as mentioned in the steps above happens.
Thanks so much, i hope i made the problem more clear this time around.
Thanks and greetings
Leo
