On Sun, Oct 28, 2018 at 10:46 PM Philip Guenther <[email protected]> wrote: > In this case, since the issue is a standards compliance issue, I'm mildly > inclined towards thinking we should fix it. For the trivial functions, > marking them static seems fine; uhci_find_prev_qh() should perhaps just > drop the 'inline': the compiler can still inline it.
I was aware of the policy, but judged I should still report it for the reason you described. Also, It seemed like a dumb thing to break the build and the fix was very simple. > 'static' should always be placed first in the declaration. C11 declared > "placement of a storage-class specifier other than at the beginning of the > declaration specifiers in a declaration" to be an obsolescent feature. I trust the OpenBSD developers are more versed in the relevant standards than me and will leave it to them to edit the fix as needed unless told otherwise. Thanks for the great work everyone.
