On Sat, Jan 05, 2019 at 07:53:04PM +1100, Jonathan Gray wrote:
> On Fri, Jan 04, 2019 at 09:56:15PM -0600, Brian Conway wrote:
> > Greetings. I have a hot-off-the-presses Intel NUC model NUC8i5BEH
> > (https://www.intel.com/content/www/us/en/products/boards-kits/nuc/kits/nuc8i5beh.html).
> > For such a recent release, just about everything that I need works
> > well, including unaccelerated wsfb X. The one thing that didn't work
> > was em0 ethernet, with the following message on boot, using both
> > 6.4-stable and -current as of 1/4/19:
>
> The next drm update will add support for apollo lake/broxton,
> gemini lake, coffee lake and whiskey lake. i5-8259U is coffee lake.
>
> >
> > em0 at pci0 dev 31 function 6 "Intel I219-V" rev 0x30: msiem0: The
> > EEPROM Checksum Is Not Valid
> > em0: Unable to initialize the hardware
> >
> > Based on my digging through the mailing lists (I217 and I218), I think
> > this may just not be supported yet? A ure0 USB 3.0 adapter is working
> > well in the meantime. Full dmesg follows, thanks.
>
> Support for the coffee lake / cannon point mac was added without
> hardware as it seems to be identical to the earlier one in most
> respects.
>
> I found a case I missed:
diff from rev 1.78 with the test fixed by kettenis
Index: if_em_hw.h
===================================================================
RCS file: /cvs/src/sys/dev/pci/if_em_hw.h,v
retrieving revision 1.76
retrieving revision 1.78
diff -u -p -r1.76 -r1.78
--- if_em_hw.h 29 Apr 2018 08:45:01 -0000 1.76
+++ if_em_hw.h 5 Jan 2019 18:46:36 -0000 1.78
@@ -87,7 +87,8 @@ typedef enum {
#define IS_ICH8(t) \
(t == em_ich8lan || t == em_ich9lan || t == em_ich10lan || \
- t == em_pchlan || t == em_pch2lan || t == em_pch_lpt || t ==
em_pch_spt)
+ t == em_pchlan || t == em_pch2lan || t == em_pch_lpt || \
+ t == em_pch_spt || t == em_pch_cnp)
typedef enum {
em_eeprom_uninitialized = 0,
