Hi Matthieu,
On Tue, Feb 05, 2019 at 08:13:44AM +0100, Matthieu Herrb wrote:
> On Mon, Feb 04, 2019 at 07:08:25PM +0000, Mikolaj Kucharski wrote:
> > Hi,
> >
> > Sorry for missing subject line in my initial report. I tested git
> > checkout of commit c37c7ee0748ba828ec5d2c7304cd2a17af2c8109 of
> > xf86-video-intel driver from:
> >
> > https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel.git
> >
> > and it seems to work for me on Huawei MateBook X and the crash reported
> > below is gone.
> >
> > From what I can see, there are rare releases of xf86-video-intel driver,
> > so would be possible to import to Xenocara git snapshot of the driver, if
> > there is no recent code release?
>
> Last time I tried there were a number of regression on some older
> hardware. If you can identify which commit is fixing the crash, I
> would be happy to check if it can be back-ported.
I spent some time git-bisect'ing the above mentioned repo and my tests
show that commit e3edf2948467ad989590a347ffe687780192be16 is the very
first commit which fixes the Xorg crash for me. I was bisecting between
692c14d405bb352697b67f36a034d4963e272b66 (2.99.916) and master at the
time 6afed33b2d673d88674f0c76efe500ae414e8e1b.
There are number of commits between what I think is in base for Xenocara
intel driver source code (692c14d405bb352697b67f36a034d4963e272b66) and
working driver:
$ git rev-list
692c14d405bb352697b67f36a034d4963e272b66..e3edf2948467ad989590a347ffe687780192be16
| wc -l
15
In that range of commits there are multiple commits which reference bug
report https://bugs.freedesktop.org/show_bug.cgi?id=77074 so I don't
think backport is going to be a single commit. I didn't look into cherry
picking some of the commits from above range, but I want to try that.
However, before going that route, is this really good direction?
Matthieu, you wrote that there were number of regressions on some older
hardware. Is it easy to reproduce the problem? Do you have access to the
affected hardware or do you know who has it and is willing to test it?
I'm asking as I'm not sure is backporting multiple commits going to
scale and what new issues may come up and what else needs to be
addressed if there will be new problems.
Anyway, I personally would prefer to focus efforts on updating the
driver to latest commit (as of today it is
6afed33b2d673d88674f0c76efe500ae414e8e1b)
Let me know, what do you think.
> The state of the xf86-video-intel driver is sad. But everyone is
> moving away from it to the modesettings driver. Hopefully the current
> work on upgrading the kernel-side DRM code and the upcoming upgrade to
> xserver 1,20.x will also improve the modesetting driver on OpenBSD, so
> that less people will need to run the intel driver.
I see. What time frame are you talking about here, when you say
"upcoming upgrade to xserver 1,20.x"?
--
Regards,
Mikolaj
