On Mon, Jun 24, 2019 at 04:28:02PM +0200, Ingo Schwarze wrote: > Hi, > > Andras Farkas wrote on Sat, Jun 22, 2019 at 02:54:01PM -0400: > > > In ksh.1, in the See Also section, this book is referenced: > > Morris Bolsky and David Korn, The KornShell Command and Programming > > Language, 2nd Edition, Prentice Hall, 1995, ISBN 0131827006. > > However, the book with that ISBN number has a different name, as > > attested to here: > > https://dl.acm.org/citation.cfm?id=545704&preflayout=flat > > and by looking up the ISBN on Google and Amazon. (I also own the book > > with this ISBN number, and can confirm those sources _are_ correct) > > So if this book is to be referenced, the title given should be: > > The New KornShell Command and Programming Language > > The reference to it being a second edition then becomes optional, and > > fine either way. > > > > However, it may be worthwhile reverting the reference to be to the > > first edition of the book: > > https://dl.acm.org/citation.cfm?id=77009&preflayout=flat > > The 2nd edition is about ksh93, while the first edition is about > > ksh88. The ksh clone in OpenBSD is not a ksh93 clone. > > > > Relevant diff where this change occurred: > > https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/bin/ksh/ksh.1.diff?r1=1.150&r2=1.151 > > Since jmc@ asked me to handle this, i committed the following patch. > > Thanks for reporting, > Ingo >
much obliged! jmc > > CVSROOT: /cvs > Module name: src > Changes by: [email protected] 2019/06/24 08:22:39 > > Modified files: > bin/ksh : ksh.1 > > Log message: > Partial revert of rev. 1.151: > Reference the First Edition (1989) of Bolsky/Korn which is about ksh88, > the shell the OpenBSD ksh(1) descends from (via pdksh). > The Second Edition (1995) of the book is about ksh93 which we don't provide. > Pointed out by Andras Farkas on bugs@. > > > Index: ksh.1 > =================================================================== > RCS file: /cvs/src/bin/ksh/ksh.1,v > retrieving revision 1.205 > retrieving revision 1.206 > diff -u -r1.205 -r1.206 > --- ksh.1 21 Jun 2019 10:49:17 -0000 1.205 > +++ ksh.1 24 Jun 2019 14:22:39 -0000 1.206 > @@ -5545,10 +5545,12 @@ > .Rs > .%A Morris Bolsky > .%A David Korn > -.%B The KornShell Command and Programming Language, 2nd Edition > -.%D 1995 > +.%B The KornShell Command and Programming Language > +.%D First Edition 1989 > .%I Prentice Hall > -.%O ISBN 0131827006 > +.%O ISBN 0135169720 > +.\" The second edition of the above book (1995) is about ksh93, > +.\" but the OpenBSD ksh is a decendant from ksh88 via pdksh. > .Re > .Rs > .%A Stephen G. Kochan
