On 06/07/19(Sat) 20:17, Klemens Nanni wrote:
> Running latest snapshot on a T5240.
> 
> The machine paniced while removing interfaces from protected domains.
> Here is the console log showing both the bridge's configuration as well
> as the commands used:

There's a mtx_leave() missing in bridge_rtfind(), I guess that's what
caused your panic.

Index: net/bridgectl.c
===================================================================
RCS file: /cvs/src/sys/net/bridgectl.c,v
retrieving revision 1.19
diff -u -p -r1.19 bridgectl.c
--- net/bridgectl.c     12 May 2019 19:53:22 -0000      1.19
+++ net/bridgectl.c     8 Jul 2019 19:03:08 -0000
@@ -531,8 +531,10 @@ bridge_rtfind(struct bridge_softc *sc, s
                LIST_FOREACH(n, &sc->sc_rts[k], brt_next) {
                        struct ifnet *ifp;
 
-                       if (i >= total)
+                       if (i >= total) {
+                               mtx_leave(&sc->sc_mtx);
                                goto done;
+                       }
                        bareq = &bareqs[i];
 
                        ifp = if_get(n->brt_ifidx);

Reply via email to