On Wed, Jul 31, 2019 at 08:29:31PM +0200, Alexander Bluhm wrote:
> On Wed, Jul 31, 2019 at 10:12:02AM -0500, [email protected] 
> wrote:
> > Synopsis:   umount says device busy after having used openrsync
>
> I have seen this behavior in combination with unveil(2) and chroot(2).
> Could you test if the same diff helps for your problem?

I have commited my fix for unveil(2) and chroot(2).  Unfortunately
there seems to be another bug that is triggert by unveil(2) and
chdir(2).  I have written a test for the latter, but I have not
found the bug yet.

bluhm

> Index: kern/kern_unveil.c
> ===================================================================
> RCS file: /data/mirror/openbsd/cvs/src/sys/kern/kern_unveil.c,v
> retrieving revision 1.29
> diff -u -p -r1.29 kern_unveil.c
> --- kern/kern_unveil.c        29 Jul 2019 23:14:06 -0000      1.29
> +++ kern/kern_unveil.c        30 Jul 2019 12:18:52 -0000
> @@ -309,8 +309,7 @@ unveil_find_cover(struct vnode *dp, stru
>                       break;
>               }
>
> -             if (parent != vp)
> -                     vrele(vp);
> +             vrele(vp);
>               (void) unveil_lookup(parent, p, &ret);
>               vput(parent);

Reply via email to