On Mon, 9 Dec 2019 at 10:44, Remi Locherer <[email protected]> wrote:
>
> >
> > I can reproduce this issue. But only when I combine the use of
> > "interface XY { passive }" and "redistribute connected". When I remove
> > the passive interfaces from ripd.conf memory consumption is stable.
> >
> > Why do you combine these configs?
>
> Below diff fixes the memory leak for me.
>
> In addition to clear r_list I also moved the check for passive interface
> a bit up so that the function can return as soon as possible.
>
> OK?
>
> Remi
>
>
>
>
This patch applied cleanly and has fixed the memory leak issue when
interfaces are configured 'passive'. Tested with 1 active and 6 passive
interfaces on one host and with a little memory consumption on startup
[expected], it settled back down to 984KB of consumed RAM for 391 subnets
and didn't move over 1.5 hours.
As /cvs/src/usr.sbin/ripd/message.c hasn't been touched since 2014, this
patch would apply cleanly to 6.5 and 6.6 if an errata notice needed to be
created (I can test on these if validation is required - will just take a
little time to spin them up).
Thanks for your help Remi.
Cheers,
Jason.
