On Wed, Jan 08, 2020 at 12:24:56PM +0100, Benjamin Baier wrote: > On Wed, 8 Jan 2020 04:31:42 -0500 > Thomas Dickey <[email protected]> wrote: > > > On Wed, Jan 08, 2020 at 09:01:32AM +0100, Benjamin Baier wrote: > > ... > > > > Thomas Dickey <[email protected]> wrote: > > ... > > > > > Reading the source, it seems that the client is asking for the target > > > > > with this information, that libXmu is "merely" capable of honoring it > > > > > for some time. Take a look at > > > > > > > > > > https://gitlab.freedesktop.org/xorg/lib/libxmu/blob/master/src/CvtStdSel.c > > > > > > > > > > (very likely, disabling the XA_HOSTNAME (and XA_IP_ADDRESS) chunks > > > > > in that file wouldn't hurt xterm, though claws-mail might be annoyed). > > ... > > > I masked this bug with a patch to claws-mail. > > > https://marc.info/?l=openbsd-ports&m=157843792723639&w=2 > > > But who knows which other applications trigger this as well? Can't test > > > all > > > of them. So I don't consider this fixed. > > > > I did point to the appropriate place to make a change. > > Perhaps someone will read my response today. > I did read and investigate, just not that knowledgeable about xterm and X11. > The offending code in LibXmu is in a #if defined(TCPCONN) block. > What's the downside of compiling this with undefined TCPCONN? > What features are we losing?
The feature's ~30 years old, so intent is hard to get, but looking down to line 309 (XA_TARGETS) that's one of several properties that someone (probably) thought would be useful for identifying the origin of a selection. Perhaps they had some authentication scheme in mind. You'd lose that -- but ordinary selections would work. Some application _may_ ask for XA_TARGETS and blindly fetch all of the properties, or it _may_ ask specifically for XA_IP_ADDRESS. I thought the former was more likely, and hinted (for OpenBSD's purposes) that limiting both to the local system would be what's needed. -- Thomas E. Dickey <[email protected]> https://invisible-island.net ftp://ftp.invisible-island.net
signature.asc
Description: PGP signature
