On Sun, Aug 23, 2020 at 11:24:46PM +0100, Jason McIntyre wrote:
> On Sun, Aug 23, 2020 at 10:16:19PM +0000, Uwe Werler wrote:
> > Hi,
> >
> > I suggest to change the wording in man 4 tpmr to avoid repetition.
> >
> > Uwe
> >
> > Index: tpmr.4
> > ===================================================================
> > RCS file: /cvs/src/share/man/man4/tpmr.4,v
> > retrieving revision 1.7
> > diff -u -p -r1.7 tpmr.4
> > --- tpmr.4 5 Aug 2020 14:55:40 -0000 1.7
> > +++ tpmr.4 23 Aug 2020 22:11:29 -0000
> > @@ -44,7 +44,7 @@ configuration file for
> > Other forms of Ethernet bridging are available using the
> > .Xr bridge 4
> > driver.
> > -Other forms of aggregation of Ethernet interfaces are available
> > +Link aggregation of Ethernet interfaces can be achieved
> > using the
> > .Xr aggr 4
> > and
> >
>
> hi.
>
> your diff changes the meaning: currently the page suggests tpmr is capable of
> (a form of) link aggregation, and aggr and trunk can be used as alternatives.
>
> with your changes, it suggests tpmr is not capable of (a form of) link
> aggregation.
>
> i don;t know whether that's correct or not. but the diff does not just
> "avoid repitition".
That diff reads OK, tpmr(4) is really a bridge like bridge(4) or
switch(4), and not an aggregating driver like aggr(4) or trunk(4), hence
"Other forms of Ethernat bridging ..." correctly implies that tpmr does
indeed ethernet bridging, "Other forms of aggregation ..." implies the
same way, but that is misleading.
