Hi,

is there something else I can do to help you with your tests?

On 14/10/20 21:09, Mark Kettenis wrote:
From: James Hastings <[email protected]>
Date: Sun, 11 Oct 2020 03:49:11 -0400 (EDT)

On Thu, 08 Oct 2020 20:29:38 +0000 Mark Kettenis wrote:
Diff below adds a driver for the GPIO controller found on the Intel
400 Series PCH as found on (for example) the Lenovo X1 gen 8 laptop.
Since I don't have such hardware, I'd appreciate some tests on laptops
that current show:

"INT34BB" at acpi0 not configured

Thanks for the driver Mark! Compiles fine here but panics like this:
ihidev0 at iic0 addr 0x2c gpio 291panic: kernel diagnostic assertion "pin >= 0 && pin < 
sc->sc_npins" failed: file "/usr/src/sys/dev/acpi/pchgpio.c", line 335

Let me know any way I can help.
Can you figure out what pin number it is trying to use?

Thanks,

Mark

P.S. Feel free to finish the driver yourself if you have time.  This
      sort of thing is way easier if you have the hardware.  The
      hardware itself should be very similar to aplgpio(4).  It's just
      that the registers moved around a bit and there is a single ACPI
      device for all the pin "communities" instead of the model of
      separate ACPI devices for each community that aplgpio(4) uses.


Reply via email to