On Thu, May 06, 2021 at 04:50:31PM +0200, Alexandr Nedvedicky wrote:
> Hello Olivier,
> >
> > This morning, I've rebuild a new --current kernel and got some panics after
> > some minutes with PFÂ enabled.
> > Then I've applied your patch and it is stable so far.
> >
>
> thank you for your help with this. I have not heard back from Sebastien
> yet.
my machine is stable with the commit reverted: up 1 day, 8:20.
> one more question:
> are you building your bsd kernel with DIAGNOSTIC option enabled?
> I think you don't, because your crash matches uvm fault due to
> use-after-free.
>
> Sebastien hit the problem earlier by KASSERT().
>
> just to summarize there are two boxes so far, which choked up with my commit
> [1].
> both boxes are quite different. yours runs bsd kernel on single core CPU:
>
> cpu0: Geode(TM) Integrated Processor by AMD PCS ("AuthenticAMD" 586-class)
> 499 MHz, \
> 05-0a-02
>
> Sebastien runs bsd.mp on two CPU cores:
> cpu0: Intel(R) Core(TM)2 Duo CPU E6750 @ 2.66GHz, 2660.30 MHz, 06-0f-0b
>
> I'm not able to trigger crash on my HW. Which is notebbok running bsd.mp on:
>
> cpu0: Intel(R) Core(TM) i5-4200U CPU @ 1.60GHz, 1496.74 MHz, 06-45-01
>
> the other box, is APU router running bsd.mp on 4 cores:
> cpu0: AMD GX-412TC SOC, 998.26 MHz, 16-30-01
>
>
> to be honest I have no idea what could be causing problems on those two fairly
> distinct machines. The strange thing is that pf_test() currently does not run
> in
> parallel. I don't quite understand why reverting my earlier change helps here.
it could be two differents ways to trigger a bug somewhere else that
your commit expose.
the panic doesn't trigger in the same way on both machines:
- Olivier's machine seems to trigger it quickly (after some minutes)
- mine relatively slowly (~ once a day)
I could try to run with your commit and see if I could trigger it more
easily or found some elements influencing it. I could try with GENERIC
for example to see if I still trigger the same assert() or if it is
more like Olivier.
my LAN was several hosts with the same kernel and only this machine
trigger the panic, so it shouldn't be strictly linked to the
environment.
Thanks.
--
Sebastien Marie