Matthieu Herrb <[email protected]> writes:
> On Mon, Nov 15, 2021 at 11:50:41AM +0100, Peter N. M. Hansteen wrote: >> On Sun, Nov 14, 2021 at 12:25:45PM +0100, Matthieu Herrb wrote: >> > On Sun, Nov 14, 2021 at 10:44:40AM +0100, Peter N. M. Hansteen wrote: >> > > On Sat, Nov 13, 2021 at 12:16:22PM +0100, Matthieu Herrb wrote: >> > > > >> > > > did I miss something or is this still pending ? >> > > >> > > I just tested, the problem unfortunately persists. >> > >> > Strange, it works for me... At least with Landry's patch the new >> > package should display the unlock dialog now that >> > /usr/local/libexec/xfce4-screensaver-dialog is not setuid anymore... >> > >> > Are you sure you built and installed the patched >> > xfce4-screensaver--4.16.0p0 package ? >> > >> > Is /usr/local/libexec/xfce4-screensaver-ask-pass properly installed >> > setgid auth ? are you using 'nosuid' on you /usr/local/partition ? >> > >> > Sorry for the newbie -like questions... > >> >> A few oddities. My /usr/local was not nosuid, so I added the nosuid >> option to that partition's line in /etc/fstab and rebooted. > > Hmm no, to have a chance to get a working xfce4-screensaver, > /usr/local should *not* be mounted nosuid (ie it should be mounted > suid, which is the default when no option is present). > >> >> After the 5 minute timeout the screensaver kicked in and touching Ctrl >> gave me a password dialog, which however did not actually accept my password. >> >> Looking for the xfce4-screensaver-ask-pass binary I do not find it at all >> on my system. That's a bit odd isn't it? > > Ok so you probably didn't install the patched version. And with > /usr/local mounted nosuid, the default helper > /usr/local/libexec/xfce4-screensaver-dialog starts (since its suid bit > is now ignored, and that was the root of the issue). > > So to summarize: you should rebuild and install the patched version to > test. > > cd /usr/ports/x11/xfce4/xfce4-screensaver > patch -p0 -E < /this/patch > doas make clean=all > doas make package FETCH_PACKAGES= > doas make install > > I'm adding Landry's patch below for reference : This resolves the issue for me!
