Daniel Dickman <[email protected]> writes:
> Here's the link to the commit Mark referenced:
> https://github.com/NetBSD/src/commit/4f9e11b0dddf04640fe0553a9133a471af613627
>
> And then the actual implementations were removed in this commit:
> https://github.com/NetBSD/src/commit/870f792ccadb412e522f37caec6028b0076a871b
>
> So I guess this is the list of functions to remove, Mark?
>
> I'm testing this on i386 with numpy to see if regress tests improve.
>
> s_cos.S
> s_cosf.S
> s_sin.S
> s_sinf.S
> s_tan.S
> s_tanf.S
This improves one of the regress tests mbuhl@ added. This one now
passes:
modified regress/lib/libm/msun/Makefile
@@ -58,7 +58,6 @@ FAILING+= run-ctrig_test-1
FAILING+= run-exponential_test-1
FAILING+= run-invtrig_test-7
FAILING+= run-next_test-{1,2,4}
-FAILING+= run-trig_test-3
. elif ${MACHINE} == arm64
FAILING+= run-cexp_test-{1,7}
FAILING+= run-ctrig_test-{1,5}
But one new test is reported broken:
==== run-trig_test-2 ====
2 tests the accuracy of these functions over the primary range
./trig_test -r 2
trig_test.c:257: 'fpequal_cs(_x, _y, 1)' evaluated to false
*** Error 1 in . (Makefile:143 'run-trig_test-2')
FAILED
So, some attention is needed in this area.
Thanks
Greg
