Hi Alexander, On Tue, Jan 18, 2022 at 01:51:45PM +0100, Alexander Bluhm wrote: > On Tue, Jan 18, 2022 at 12:59:25PM +0100, Christian Ehrhardt wrote: > > If so, any volunteers to commit this? > > Done. Thanks for fixing this. > > Two more things: > > - We need a man page update. I think the missing documentation > of this feature was the reason that this bug was introduced. > - The strange M_EXT check with the XXX comment in ip input was the > reason I looked into this topic long time ago. I think a M_READONLY > would make the intention more obvious. > > ok? > > bluhm > > > Index: share/man/man9/mbuf.9 > =================================================================== > RCS file: /data/mirror/openbsd/cvs/src/share/man/man9/mbuf.9,v > retrieving revision 1.123 > diff -u -p -r1.123 mbuf.9 > --- share/man/man9/mbuf.9 8 Mar 2021 02:47:26 -0000 1.123 > +++ share/man/man9/mbuf.9 13 Jan 2022 14:36:53 -0000 > @@ -570,7 +570,7 @@ is freed. > Ensure that the data in the mbuf chain starting at the beginning of > the chain and ending at > .Fa len > -will be put in continuous memory region. > +will be put in continuous and writable memory region.
This is not true. If the data is already contiguous (the default)
the buffer where the data lives may still be read-only.
regards Christian
smime.p7s
Description: S/MIME cryptographic signature
