On Fri, Jan 28, 2022 at 06:17:58AM -0700, Thomas Frohwein wrote:
> On Thu, 27 Jan 2022 06:16:04 -0700
> Thomas Frohwein <[email protected]> wrote:
> 
> > > > Wanted to clarify my reddit post:
> > > > There is a problem when the install is encrypted (full disk encryption, 
> > > > w
> > > > bioctl).
> > > > Unencrypted version works fine (got to the login).
> > > > 
> > > > When finding this bug, I tried:
> > > > - sysupgrade -s
> > > > - fresh install w install70.img
> > > >     
> > > > Reproduction:    
> > > > 1. encrypt the disk with bioctl -c C -l $yourdisk softraid0
> > > > 2. installation    
> > > 
> > > It is interesting you see a difference with softraid.
> > > I've not been able to reproduce this on a x250 with broadwell/gen8
> > > graphics with root on encrypted softraid.  
> > 
> > I am using a softraid-encrypted drive, too. I'm getting another drive
> > this week; will try install on that one without and then with softraid
> > and see if I can reproduce the findings.
> 
> Just to close the loop on this: I got the new drive, did a new install
> without softraid encryption. The same pmap kernel panic happens as with
> my other, encrypted drive. Again, booting bsd.sp works around this.

does this diff to revert uvm_fault.c rev 1.124 change anything?

Index: sys/uvm/uvm_fault.c
===================================================================
RCS file: /cvs/src/sys/uvm/uvm_fault.c,v
retrieving revision 1.124
diff -u -p -r1.124 uvm_fault.c
--- sys/uvm/uvm_fault.c 28 Dec 2021 13:16:28 -0000      1.124
+++ sys/uvm/uvm_fault.c 29 Jan 2022 04:09:38 -0000
@@ -636,8 +636,10 @@ uvm_fault(vm_map_t orig_map, vaddr_t vad
                                        error = EACCES;
                        } else {
                                /* case 2: fault on backing obj or zero fill */
+                               KERNEL_LOCK();
                                error = uvm_fault_lower(&ufi, &flt, pages,
                                    fault_type);
+                               KERNEL_UNLOCK();
                        }
                }
        }

Reply via email to