On 2022-04-27 15:37 -06, Todd C. Miller <mill...@openbsd.org> wrote: > florian@ committed a fix for this the other day: >
No, that was for something else. Here the server violates the spec. In the other diff we were violating the spec. We should probably just ignore the domainname and hostname if they have a length < 1. We are only using the values in the installer. I think we are getting prompted by the installer to fill the values in if they are not present. I'll come up with a diff in the next few days. The diff is not difficult but I want to check that we handle the new corner case of no hostname / domainname passed to the main process correctly. > http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sbin/dhcpleased/frontend.c.diff?r1=1.28&r2=1.29 > > CVSROOT: /cvs > Module name: src > Changes by: flor...@cvs.openbsd.org 2022/04/26 08:50:04 > > Modified files: > sbin/dhcpleased: frontend.c > > Log message: > Do not send a hostname option when we don't have a hostname. > > The minimum length of a hostname is 1 according to RFC 2132. > Found the hard way by Ibrahim Khalifa (ibo AT trukonsult.se) with DHCP > Relay on a Cisco ASA in the installer where we don't have a hostname > yet. > Ibrahim also provided a diff which I simplified a bit. > OK tb > -- I'm not entirely sure you are real.
