Re: Display regression - flickers with every mouse movement

[Jonathan Gray]

On Mon, Sep 12, 2022 at 01:54:11PM +0200, Matthias Schmidt wrote:
> Hi Jonathan,
> 
> * Jonathan Gray wrote:
> > 
> > Can you remove the lines added in the diff one at a time
> > to figure out which specific parameter is involved?
> 
> Result of commenting each of the following variables individually,
> building a new kernel and rebooting each time.
> 
> dev_priv->params.panel_use_ssc        -> no flickering
> dev_priv->params.enable_dc            -> no flickering
> dev_priv->params.enable_fbc   -> no flickering
> dev_priv->params.enable_psr   -> flickers
> dev_priv->params.disable_power_well -> no flickering
> dev_priv->params.enable_ips   -> no flickering
> 
> Then I built another kernel and commented all of the above expect
> for enable_psr.  This also leads to no flickering.
> 
> I didn't test all possible permutations :)  Is there anything else I
> should test?

thanks for testing all of these

I'll commit the following:

Index: sys/dev/pci/drm/i915/i915_drv.c
===================================================================
RCS file: /cvs/src/sys/dev/pci/drm/i915/i915_drv.c,v
retrieving revision 1.144
diff -u -p -r1.144 i915_drv.c
--- sys/dev/pci/drm/i915/i915_drv.c     8 Sep 2022 11:30:32 -0000       1.144
+++ sys/dev/pci/drm/i915/i915_drv.c     12 Sep 2022 12:01:54 -0000
@@ -2414,6 +2414,7 @@ inteldrm_attach(struct device *parent, s
        i915_params_copy(&dev_priv->params, &i915_modparams);
        dev_priv->params.enable_guc = 0;
        dev_priv->params.request_timeout_ms = 0;
+       dev_priv->params.enable_psr = 0;
 
        /* Setup the write-once "constant" device info */
        device_info = mkwrite_device_info(dev_priv);