On Tue, 13 Dec 2022, Jason McIntyre wrote: > On Mon, Dec 05, 2022 at 01:29:26PM -0800, Richard Narron wrote: > > Here is an new version of the 5 patches with changes to two files: > > > > calendars/calendar.christian > > advent.c > > > > The file, calendar.christian, Advent entries are changed > > from: > > > > 11/SunLast First Sunday of Advent (4th Sunday before Christmas) > > 12/SunFirst First Sunday of Advent (4th Sunday before Christmas) > > > > to: > > > > Advent First Sunday of Advent (4th Sunday before Christmas) > > > > for now i have removed "11/SunLast". that should give us at least a > couple of years to deliberate this diff. > > unless someone picks it up, i will gently remind fans of > calendar.christain of its description in calendar(1): > > calendar.christian Christian holidays (should be updated > yearly by the local system > administrator so that roving holidays > are set correctly for the current > year).
The fact that there are two Advent entries in the calendar.christian table and the man page mentioning "fixing" the calendar.christian table reminds me of an old lightbulb joke: -------------------------------------------------------------------- How many hardware engineers does it take to change a lightbulb? None: "We'll fix it in software." How many software engineers does it take to change a lightbulb? None: "We'll document it in the manual." How many tech writers does it take to change a lightbulb? None: "The user can work it out." ------------------------------------------------------------------- If you are not going to use the code you might as well leave both Advent entries 11/SunLast and 12/SunFirst alone because one of them will be correct and one will be wrong. I took a different approach from "We'll document it in the manual" and "The user can work it out". I shut up and coded. Richard Narron
