npppd.conf syntax error in ipcp block using address-mask

[Ryan Freeman]

Hi,

Noticed this on OpenBSD 7.2 (and 7.1), confirmed still an issue on Mar 21
snapshot as well.

npppd.conf(5) states:
     pool-address address-range | address-mask [for dynamic | static]
             Specify the IP address space that is pooled for this IPCP
             setting.  The address space can be specified by address-range
             (e.g. 192.168.0.2-192.168.0.254) or address-mask (e.g.
             192.168.0.0/24).  dynamic means the address space is reserved for
             dynamic allocation; static means the address space is reserved
             for static allocation.  The default is dynamic.  This option can
             be used multiple times.

address-mask is not accepted by the parser:

ipcp IPCP {
        #pool-address 10.0.0.2-10.0.0.254
        pool-address 10.0.1.0/24
        dns-servers 8.8.8.8
}

15:28 ryan@insomniac:~$ doas npppd -n
2023-03-23 15:28:40:CRIT: /etc/npppd/npppd.conf:23: syntax error
2023-03-23 15:28:40:CRIT: /etc/npppd/npppd.conf:28: ipcp IPCP is not found
2023-03-23 15:28:40:CRIT: /etc/npppd/npppd.conf:29: interface pppx0 is not found

address-range is OK:

ipcp IPCP {
        pool-address 10.0.0.2-10.0.0.254
        #pool-address 10.0.1.0/24
        dns-servers 8.8.8.8
}

15:30 ryan@insomniac:~$ doas npppd -n
configuration OK


I've been sitting on this for a couple months and was just reminded, apologies
for the delay!

Thanks,
-Ryan