On Sat, Dec 09, 2023 at 02:07:06AM +0300, Vitaliy Makkoveev wrote: > > > SLIST_ENTRY(pflow_softc) sc_next; > > > > This list is protected by net lock. Can you add an [N] here? > > > > This is not true. The netlock is not taken while export_pflow() called > from pf_purge_states(). I privately shared the diff to fix this, but not > committed it yet. I will update it and share after committing this diff.
Why not hold the shared net lock while in pf? My stategy is to convert exclusive net lock to shared net lock step by step. When this is complete, we can remove net lock completely. Until that happens, we hold exclusive net lock in corner cases and know that nothing can go wrong. Seems to be easier than to be aware of pflowif_list locking when working on pf. bluhm
