Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/90 was reviewed by Gedare Bloom
-- Gedare Bloom started a new discussion on bsps/shared/dev/spi/xqspipsu-flash-helper.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/90#note_107960 > + } > + > + return 0; use `XST_SUCCESS`? -- Gedare Bloom started a new discussion on bsps/shared/dev/spi/xqspipsu-flash-helper.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/90#note_107961 > + rtems_status_code sc = rtems_event_transient_send(TransferTask); > + if (sc != RTEMS_SUCCESSFUL) { > + Error++; Unrelated to this patch, can we change how this global `Error` variable is being used? We should generally avoid having global symbols. This file has a few of them. I understand some of this comes from the Xilinx code, but we appear to be modifying this stuff heavily already. -- Gedare Bloom started a new discussion on bsps/shared/dev/spi/xqspipsu-flash-helper.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/90#note_107962 > #define EXIT_4B 0 > > +#define NOR_TIMEOUT_US 5000000U I guess 5 seconds is a long enough time for any reasonable timeout, but should this be configurable? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/90 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
