Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/103 
was reviewed by Utkarsh Verma

--
  
Utkarsh Verma started a new discussion on 
bsps/aarch64/raspberrypi/include/bsp/spi.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/103#note_108829

 > +  uint32_t spics;
 > +#define RPI_SPICS_LEN_LONG BSP_BIT32(25)
 > +#define RPI_SPICS_DMA_LEN BSP_BIT32(24)

Align macros

--
  
Utkarsh Verma started a new discussion on bsps/aarch64/raspberrypi/spi/spi.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/103#note_108830

 > +}
 > +
 > +#define GPU_CORE_CLOCK_RATE 500000000

This depends on the System hence should not be handcoded here. How did you 
account for the system - clock?

--
  
Utkarsh Verma started a new discussion on bsps/aarch64/raspberrypi/spi/spi.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/103#note_108831

 > +    raspberrypi_gpio_set_pull(8, GPIO_PULL_NONE);
 > +    raspberrypi_gpio_set_function(9, GPIO_AF0);      //MISO
 > +    raspberrypi_gpio_set_function(10, GPIO_AF0);     //MOSI

Stray C99 comments.




-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/103
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to