Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118 
was reviewed by Kinsey Moore

--
  
Kinsey Moore started a new discussion on cpukit/posix/src/aio_misc.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109396

 > +void rtems_aio_notify( struct sigevent *sig ) 
 > +{
 > +  #ifdef RTEMS_POSIX_API

\# directives in RTEMS are typically placed at the beginning of the line either 
with no indentation at all or their own indentation unrelated to the code. This 
applies elsewhere.

--
  
Kinsey Moore started a new discussion on cpukit/posix/src/aio_misc.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118#note_109397

 > +      break;
 > +  }
 > +  #endif

I'd recommend an #else clause here with "(void)sig;" to avoid unused argument 
warnings.




-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/118
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to