Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86 was 
reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on 
cpukit/include/rtems/confdefs/extensions.h: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_109556

 > +  #else
 > +    const Stack_checker_Reporter_handler Stack_checker_Reporter =
 > +      rtems_stack_checker_reporter_quiet; 

Please do not change from the current noisy reporter to a quiet one as part of 
adding this functionality. This will change behaviour for users from the noisy 
reporter which has the default since before May 1995 when the git history 
starts. 

Add the configuration option with the noisy reporter in this MR. File an issue 
to change the reporter to the quiet one. This will let us have a discussion 
solely on that change of behaviour. You can resolve this comment by filing an 
issue.

--
  
Joel Sherrill commented on a discussion on 
testsuites/libtests/stackchk03/init.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_109557

 > +
 > +/*
 > + * Copyright (C) 2024 On-Line Applications Research Corporation (OAR)

Entire separate lines for each party:

```
Copyright (C) 2024 On-Line Applications Research Corporation (OAR)
Copyright (C) 2024 Mohamed Hassan <[email protected]>
```




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to