Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86 was 
reviewed by Joel Sherrill

--
  
Joel Sherrill started a new discussion on testsuites/libtests/stackchk/init.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_109761

 >  
 >  #define CONFIGURE_INIT
 > +#include "../stackchk03/system.h"

I don't understand this include followed by an include of a local directory 
system.h.

--
  
Joel Sherrill started a new discussion on testsuites/libtests/stackchk/init.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86#note_109762

 >  const char rtems_test_name[] = "STACKCHK";
 >  
 > +void stackchk03_blown_stack_reporter(

Why is stackchk03 in here? Move stackchk and stackchk03 specifics into their 
own files. Their unique code should not be intermingled.




-- 
View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/86
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to