Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/134 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on bsps/i386/pc386/config/pc386.cfg: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/134#note_110022 > # optimize flag: typically -O2 > CFLAGS_OPTIMIZE_V = -O2 -g > -# Per function sections disabled per https://devel.rtems.org/ticket/2638 Remove this comment. Per functions are clearly enabled in the arguments. That is an 8 year old ticket and is closed. -- Joel Sherrill started a new discussion on cpukit/score/cpu/sparc/cpu.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/134#note_110023 > > -/* https://devel.rtems.org/ticket/2352 */ > +/* https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/2352 */ This is closed. Can the comment be "See .. for explanation"? Sorry to push clarifying comments while updating URLs but when I see a comment like that, I expect an open issue -- not a link to a long closed issue that explains what this is doing. :( -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/134 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
