Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/163 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on cpukit/libdebugger/rtems-debugger-powerpc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/163#note_110482 > + * The `sc` instruction > + */ > +//#define TARGET_BKPT 0x44000002 Why is this commented out? And why use C++ comments -- Joel Sherrill started a new discussion on cpukit/libdebugger/rtems-debugger-powerpc.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/163#note_110483 > + * There are two classes of debug exception types: > + * > + * Type 1: exception before instruction Shouldn't these be aligned? -- Joel Sherrill started a new discussion on cpukit/libdebugger/rtems-debugger-server.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/163#note_110484 > rtems_debugger_printf("rtems-db: shutdown\n"); > + sleep(2); > rtems_fatal_error_occurred(1122); Do you want to define an error code in rtems/score/interr.h and use that here? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/163 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
