Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on bsps/x86_64/amd64/interrupts/idt.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_110596 > /* XXX */ Can you turn this into a meaningful comment? Does this need functionality? -- Joel Sherrill started a new discussion on bsps/x86_64/amd64/interrupts/idt.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_110597 > +) > +{ > + /* TODO */ Just for bookkeeping, will there or is there a ticket for this feature? -- Joel Sherrill started a new discussion on bsps/x86_64/amd64/interrupts/isr_handler.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_110598 > /* Add SPDX. -- Joel Sherrill started a new discussion on bsps/x86_64/amd64/interrupts/isr_handler.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_110599 > .set ALIGNMENT_MASK, ~(CPU_STACK_ALIGNMENT - 1) > andq $ALIGNMENT_MASK, rsp > // XXX: Save interrupt mask? Is this resolved? Should it be a C++ comment or C comment? -- Joel Sherrill started a new discussion on bsps/x86_64/amd64/start/ap_trampoline.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_110600 > +/* > + * SPDX-License-Identifier: BSD-2-Clause Split SPDX into its own 1 line comment followed by a blank line. -- Joel Sherrill started a new discussion on bsps/x86_64/amd64/start/ap_trampoline.S: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_110601 > + */ > + > +/** This should be an @file Doxygen block after the SPDX. -- Joel Sherrill started a new discussion on bsps/x86_64/amd64/start/bspstart.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169#note_110602 > #endif > paging_init(); > + assert(acpi_tables_initialize()); I don't think you should use C Library assert(). _Assert() is RTEMS debug only assert and should be used here. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/169 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
