Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on cpukit/include/rtems/imfs.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_124738 > IMFS_directory_t Root_directory; > const IMFS_mknod_controls *mknod_controls; > + int IMFS_jnode_count; This doesn't have to start with IMFS_ since it is inside a structure. -- Joel Sherrill started a new discussion on cpukit/include/rtems/imfs.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_124739 > - * The following rouine puts the symbolic links destination name into > + * The following routine puts the symbolic links destination name into > * buff. If buff is a parameter, then put a @a in front of it. You have been good at catching spelling errors. As you spot places in need of @a, just add it. -- Joel Sherrill started a new discussion on testsuites/psxtests/psximfs01/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_124740 > + int rc = statvfs(FILE_NAME, &imfs_statvfs); > + rtems_test_assert(rc == 0); > + printf("Block Size: %ld\n", imfs_statvfs.f_bsize); The answers to these prints should be known. Turn it into an rtems_test_assert() so the test doesn't print more. -- Joel Sherrill commented on a discussion on cpukit/libfs/src/imfs/imfs_statvfs.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504#note_124741 > + buf->f_blocks = UINT_MAX / IMFS_MEMFILE_BYTES_PER_BLOCK; > + buf->f_bfree = malloc_free_space() / IMFS_MEMFILE_BYTES_PER_BLOCK; > + buf->f_bavail; Remember that the allocator plugin will have to have a free space function. Make a note of that and mark this comment resolved when you have made a note of it. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/504 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
