Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/636 
was reviewed by Chris Johns

--
  
Chris Johns started a new discussion on 
cpukit/libdebugger/rtems-debugger-server.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/636#note_127743

 >    const char* lm_str;
 >    uint64_t target_address;
 > +  Context_Control *context = NULL;

This should be: `Context_Control* context = NULL;`

The `context` is of type `Context_Control*` and so a pointer

--
  
Chris Johns started a new discussion on 
cpukit/libdebugger/rtems-debugger-server.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/636#note_127744

 > -  target_address = thread->tcb->Registers.thread_id;
 > +  context = &thread->tcb->Registers;
 > +  target_address = (uintptr_t)_CPU_Get_TLS_thread_pointer(context);

```c
target_address = 
  (uintptr_t) _CPU_Get_TLS_thread_pointer(&thread->tcb->Registers);
```

so the local variable is not needed?


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/636
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to