Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/534 was reviewed by Gedare Bloom
-- Gedare Bloom started a new discussion on cpukit/include/rtems/imfs.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/534#note_128312 > + > +/* > + */ Empty comment? -- Gedare Bloom started a new discussion on cpukit/include/rtems/imfs.h: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/534#note_128313 > + * > + * @param allocate The function which will be used to allocate IMFS blocks. > + * @param deallocate The function to deallocate the allocated data blocks > from allocate function. Line lengths over 80 -- Gedare Bloom started a new discussion on cpukit/libfs/src/imfs/imfs_initsupp.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/534#note_128314 > IMFS_assert( root_node != NULL ); > > + // IMFS_memfile_ops_init(); Don't include commented out code -- Gedare Bloom commented on a discussion on cpukit/libfs/src/imfs/imfs_memfile.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/534#note_128315 > #include <string.h> > > +extern IMFS_memfile_ops imfs_memfile_ops; Should this be declared in a header file? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/534 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
