Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670 was reviewed by Sebastian Huber
-- Sebastian Huber started a new discussion on cpukit/posix/src/timespecget.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670#note_128999 > +int timespec_get(struct timespec *ts, int base) > +{ > + if( !ts ){ `if ( ts == NULL ) {` -- Sebastian Huber started a new discussion on cpukit/posix/src/timespecget.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670#note_129000 > + > +#include <time.h> > +#include <errno.h> Not needed: errno.h, rtems/seterr.h, rtems/timespec.h. -- Sebastian Huber started a new discussion on testsuites/psxtests/psxtimes01/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670#note_129001 > clock_t _times_r(struct _reent *ptr, struct tms *ptms); > clock_t _times(struct tms *ptms); > +void test_times_functions(void); Use static functions. -- Sebastian Huber started a new discussion on testsuites/psxtests/psxtimes01/init.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670#note_129002 > +#include <time.h> > #include <errno.h> > +#include <rtems/score/todimpl.h> Do we really need this internal header file? -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/670 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
