Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/820 
was reviewed by Chris Johns

--
  
Chris Johns started a new discussion on 
cpukit/libdebugger/rtems-debugger-server.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/820#note_135589

 > -    r = rtems_debugger_target_start_memory_access();
 > -    if (r == 0) {
 > +    if (rtems_debugger_target_start_memory_access() == 0) {

Can you please add a comment similar to the MR description here? It is 
important and not easy to see without a comment. I needed to reread the MR 
description to understand the change.


-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/820
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to