Vijay Banerjee commented: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/882#note_138299 Hey @karthikey_kadati. Thanks for your efforts in trying to get this patch upstream. I have a few general concerns/questions: * A lot of the code is coming from JunjieShi, as per the copyright notice. I assume that some code is being imported from other authors for RTEMS. Does the original source of the patch have an open source license that is compatible with RTEMS? It would be incorrect to re-license their code as BSD-2 if they have a non-compatible license. We can, of course, ask the authors if they are okay with relicensing. * Generally, the process for importing outside code to RTEMS is to have a single "Import" commit that brings in all the outside code, and a "Port" commit that contains all your modifications specifically made for RTEMS. * The patches contain some whitespace changes. It is generally a good idea to put the required whitespace/formatting changes as a separate commit instead of combining them with functional commits -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/882#note_138299 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
