Amar Takhar commented on a discussion: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/877#note_138306 This looks great -- I do have a couple of comments. There's no need to delete files they're going to be in the repository anyway and it's just more work to delete them on every new import. Also., the other modifications you've made are they strictly necessary? The purpose to moving to a contrib directory is to expose what our "load" is to carry 3rd party dependencies. This way we can distill them down to the smallest change as possible and upstream ones that we feel should be upstreamed. Historically it's been an issue to update dependencies since changes were hidden but at the same time it's unlikely for it to be done when there are a lot of changes that make it hard to see what's actually required since only you as the author really know that without the rest of us digging into it. Again thanks for the excellent contribution. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/877#note_138306 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
