Shaunak Datar commented on a discussion on 
bsps/aarch64/raspberrypi/start/mailbox.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/915#note_139225

 > +  while (BCM2835_REG(BCM2711_MBOX_STATUS) & BCM2711_MBOX_FULL) {
 > +  }
 > +
 > +  BCM2835_REG(BCM2711_MBOX_WRITE) =
 > +      (data & MBOX_MAIL_DATA_MASK) | (channel & MBOX_MAIL_CHANNEL_MASK);
 > +}
 > +
 > +uint32_t rpi_mbox_read(bcm2711_mbox_channel channel) {
 > +  uint32_t data;
 > +  while (1) {
 > +    while (BCM2835_REG(BCM2711_MBOX_STATUS) & BCM2711_MBOX_EMPTY) {
 > +    }
 > +    data = BCM2835_REG(BCM2711_MBOX_READ);
 > +
 > +    if ((data & MBOX_MAIL_CHANNEL_MASK) == channel) {
 > +      return data & MBOX_MAIL_DATA_MASK;

A mutex lock would make more sense here, wouldn't it @c-mauderer

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/915#note_139225
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to