Kinsey Moore started a new discussion on cpukit/score/src/corerwlockrelease.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140144 > } > > _Assert( > - the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_WRITING > - || ( the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_READING > - && the_rwlock->number_of_readers == 0 ) > + the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_WRITING || > + ( the_rwlock->current_state == CORE_RWLOCK_LOCKED_FOR_READING && > + the_rwlock->number_of_readers == 0 ) I see lots of changes like this (and moving `=` as well) and I don't remember if this was directly addressed by conversations that we had, but the guidelines say `Note that each expression that resolves to a boolean goes on its own line. Where you place the boolean operator is a matter of choice.` while the only example provided is trailing operators. Using leading operators allows easier scanning across the expressions and is my preference, but if discussion was had to resolve the ambiguity in the docs and I missed it I can accept that. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/747#note_140144 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
