Joel Sherrill commented on a discussion on bsps/powerpc/tqm8xx/spi/spi.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1009#note_141572

 >  #if defined(DEBUG)
 >    printk("... exit OK, rc=%d\r\n",bc);
 >  #endif
 > -  return (rc == RTEMS_SUCCESSFUL) ? bc : -rc;
 > +  if (rc == RTEMS_SUCCESSFUL) {
 > +    return bc;
 > +  }
 > +  return -rc;

Yes. There were a few inline conditionals like this where rc (enum 
rtems_status_code) is checked and either an integer or negative 
rtems_status_code is returned. Breaking it apart addressed these sign-compare 
warnings without adding any csats.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1009#note_141572
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to