Dhruva P V commented: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5137#note_142175


Hey @opticron , I am  looking at this issue, here are the things i was able to 
evaluate:

Handling:

\-The FDT pointer isn't checked for these conditions:

1. Null condition
2. Is not verified with its FDT header.

   I have doubt  whether to add the checks within the bsp_get_get() function in 
the fdt.c file  or to add it after the pointer is returned in 
riscv_find_harts() in BSPstart. c file.

Allignment:

This BSP consumes both native system FDT pointer and bootlader pointer, so to 
tackle it -

1. Provide alignment at the C- array
2.  Check alignment at the runtime for both.

Naming -

I wasnt able to figure out the variable which variables needed uniform namings.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/issues/5137#note_142175
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to