Gedare Bloom commented on a discussion on 
bsps/aarch64/raspberrypi5/console/console.c: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1006#note_142340

 > +  handler = &arm_pl011_fns;
 > +
 > +  rtems_termios_initialize();
 > +
 > +  sc = rtems_termios_device_install( "/dev/console", handler, NULL, 
 > &rpi5_uart_debug_context.base );
 > +  if ( sc != RTEMS_SUCCESSFUL ) {
 > +    bsp_fatal( BSP_FATAL_CONSOLE_INSTALL_1 );
 > +  }
 > +
 > +  return RTEMS_SUCCESSFUL;
 > +}
 > +
 > +BSP_output_char_function_type BSP_output_char = output_char;
 > +BSP_polling_getchar_function_type BSP_poll_char = poll_char;
 > +
 > +#ifdef __cplusplus /* __cplusplus */

Don't resolve threads yourself, comment that you addressed problems and let the 
reviewer resolve the thread.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/1006#note_142340
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to